Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Add separate blockSpeaking status for acre direct #8904

Merged
merged 2 commits into from
May 8, 2022

Conversation

tbeswick96
Copy link
Contributor

When merged this pull request will:

  • Add new status effect blockSpeaking to block acre direct voice
  • Set blockSpeaking in setUnconsciousState

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@jonpas jonpas added kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:** and removed kind/bug-fix Release Notes: **FIXED:** labels May 8, 2022
@jonpas jonpas added this to the 3.14.2 milestone May 8, 2022
@jonpas jonpas requested a review from PabstMirror May 8, 2022 14:45
@@ -31,7 +31,6 @@ if (_setVolume) then {
2 fadeSound NORMAL_LEVEL;

// TFAR
_unit setVariable ["tf_voiceVolume", NORMAL_LEVEL, true];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also good to move this public setVar behind a isModLoaded check

@PabstMirror PabstMirror merged commit 27c5464 into acemod:master May 8, 2022
@tbeswick96 tbeswick96 deleted the block-speaking branch May 8, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants