Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions - Rust #9015

Merged
merged 70 commits into from
Aug 17, 2024
Merged

Extensions - Rust #9015

merged 70 commits into from
Aug 17, 2024

Conversation

BrettMayson
Copy link
Member

@BrettMayson BrettMayson commented Aug 27, 2022 •
edited
Loading

When merged this pull request will:

  • Merge all extensions into one
  • It's now in Rust though
  • Use fancy callExtension features instead of : deliminated strings

TODO:

  • advanced_ballistics
  • artillerytables
  • break_line
  • clipboard
  • fcs

Medical and dynload are no longer needed

@BrettMayson BrettMayson marked this pull request as ready for review August 31, 2022 00:10
@PabstMirror
Copy link
Contributor

PabstMirror commented Aug 31, 2022 •
edited by BrettMayson
Loading

take a look at number formatting

Rust

20220830193305_1

Old

20220830193501_1

@BrettMayson
Copy link
Member Author

BrettMayson commented Aug 31, 2022 •
edited
Loading

take a look at number formatting

fixed, 3rd column still has a decimal but it fits, should it be set back to whole values?

Fixed

image

@jonpas jonpas added this to the 3.18.0 milestone Jun 13, 2024
@jonpas jonpas added kind/feature Release Notes: **ADDED:** target/next-milestone? labels Jun 13, 2024
LinkIsGrim and others added 4 commits June 20, 2024 01:13
@LinkIsGrim @PabstMirror
semicolon
ca7ccf3 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim @PabstMirror
fix max/min
df8fd3b 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim @PabstMirror
variable name
bbde68f 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim
Merge remote-tracking branch 'origin/master' into pr/BrettMayson/9015
38c8eb0
@johnb432
Copy link
Contributor

Do we want to keep references to the medical extension or can I make a PR removing said references?

@LinkIsGrim
Copy link
Contributor

I think we should setup some ingame unit tests for extensions where possible before going through with this, for sanity's sake.

@LinkIsGrim
Copy link
Contributor

AB LGTM

johnb432 and others added 3 commits June 24, 2024 21:27
@johnb432
Update fnc_checkFiles.sqf
0464be6
@BrettMayson
update EPSILON for newer rust versions
1d37820
@BrettMayson
Extension: get loadout from clipboard (#5)
c46023a 
* extension: get loadout from clipboard

* don't need to add the errors

* don't need to add the errors

* use arma-rs loadout parser

* remove unused imports
@PabstMirror PabstMirror mentioned this pull request Jul 25, 2024
Open
@LinkIsGrim LinkIsGrim mentioned this pull request Jul 31, 2024
Merged
LinkIsGrim
LinkIsGrim approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@LinkIsGrim
Copy link
Contributor

Green button go brrt

@LinkIsGrim LinkIsGrim merged commit 043b390 into acemod:master Aug 17, 2024
5 checks passed
@BrettMayson BrettMayson deleted the rust branch August 17, 2024 16:40
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@BrettMayson @Eathox
@PabstMirror @LorenLuke @LinkIsGrim @johnb432 @blake8090
Extensions - Rust (acemod#9015)
6bd1e0b 
Co-authored-by: Pepijn Holster <pgaholster@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: LorenLuke <LukeLLL@aol.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eathox Eathox Eathox left review comments

@jonpas jonpas jonpas left review comments

@veteran29 veteran29 veteran29 left review comments

@zharf zharf zharf left review comments

@rautamiekka rautamiekka rautamiekka left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:** target/next-milestone?
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
10 participants
@BrettMayson @PabstMirror @jonpas @johnb432 @LinkIsGrim @rautamiekka @zharf @veteran29 @Eathox @LorenLuke