Markers - Add the option for UTC/System time timestamps #9121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added UTC Time zone Added UTC time offset slider Added translation in stringtable
Fixed mistake that added offset twice
- Fixed calculating error
Was a bit enthusiastic with removing tabs. This should to the trick.
|
Hope this fixed the "Tab detected at ..." problem. Otherwise I have no idea how to fix it. It has maybe to do with my VSCode sqf formatting plugin. |
- Checked SQF with sqf_validator.py - Fixed decimal error by CBA menu
|
Sorry for the amount of commits, but finaly found the problem. Changed the indenting tabs to spaces. Checked the sqf by running the validation myself and that seemed to work. |
- This does not belong here
Added empty line back
LinkIsGrim
requested changes
Jul 9, 2023
Formatting update Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Formatting update Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Added newline at end of file
Fixed fnc header formatting
LinkIsGrim
reviewed
Aug 10, 2023
Formatting Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Updated formatting
jonpas
added
kind/feature
LinkIsGrim
reviewed
Nov 12, 2023
LinkIsGrim
approved these changes
Nov 12, 2023
johnb432
requested changes
Nov 12, 2023
johnb432
reviewed
Nov 12, 2023
Allow UTC minutes offset for marker timestamp
|
@johnb432 I'm finished. Hope this works. I've tested it and it worked great for me. Good luck 😄 |
johnb432
reviewed
Nov 14, 2023
johnb432
reviewed
Nov 14, 2023
…nto markerSysTime
…nds offset" This reverts commit d2599bd.
johnb432
approved these changes
Nov 15, 2023
LinkIsGrim
requested changes
Nov 15, 2023
LinkIsGrim
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Discussion: #9119
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.