Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging - Corpse carrying and dragging - continued #9273

Merged
merged 59 commits into from
Sep 7, 2024
Merged

Dragging - Corpse carrying and dragging - continued #9273

merged 59 commits into from
Sep 7, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jul 20, 2023 •
edited
Loading

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

encountered some weird invisibility and body duplication
https://www.youtube.com/watch?v=gvnRnQPhjf0

@johnb432
Copy link
Contributor Author

johnb432 commented Jul 21, 2023 •
edited
Loading

Changelog of b32ad48:

  • Added actions to dead units. I do not know of any downsides of using allDeadMen to get all dead units, so I went with that. Extended EH don't seem to trigger on dead units, that's why this was needed.
  • Added some delays for clone creation and deletion, in order to get their corpses to be synced better. On my end the duplication of bodies is gone, but I haven't tested on a dedicated server.
  • Corpse is removed from garbage collector, so that it can be kept. If it's deleted through other manners, the unit will just drop the clone (as opposed to before, when it kept the clone on their back) and clone will be deleted.

@johnb432 johnb432 mentioned this pull request Jul 21, 2023
Merged
3 tasks
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Jul 24, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.1 milestone Sep 6, 2023
@PabstMirror PabstMirror modified the milestones: 3.16.1, Ongoing Oct 18, 2023
LinkIsGrim
LinkIsGrim previously approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues observed when testing with a small player count (8 players). Code LGTM.

We'll never get full scale testing done, banana principle it is IMO.

@LinkIsGrim LinkIsGrim self-requested a review August 27, 2024 04:41
@PabstMirror
Copy link
Contributor

super-rare but clones can drown - (getOxygenRemaining drops)
but I don't think it's a big deal, u really have to try to get them into this situation
image

@PabstMirror
Copy link
Contributor

Everything seems to work great in mp
I could see this possibly causing problems with some kind of mission scripts/triggers because the real body doesn't move
and acre radios on int-audio won't update their location as the body is moved

nothing that I think is serious, but would be nice to have a setVar just in-case people need it

johnb432 and others added 5 commits September 5, 2024 10:08
@johnb432 @PabstMirror
Update addons/dragging/functions/fnc_canCarry.sqf
b3abb78 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@johnb432 @PabstMirror
Update addons/dragging/functions/fnc_canDrag.sqf
b5579eb 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@johnb432 @PabstMirror
Update addons/medical_status/functions/fnc_addInventoryActions.sqf
7529931 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@johnb432
Merge branch 'master' into pr/9273
46bf462
@johnb432
Improve corpse dragging
ba1bda8 
- Fix drowning issue
- Add 3rd party support
- Remove "moved too far away" message if started carrying/dragging from medical menu
@johnb432 johnb432 requested a review from PabstMirror September 5, 2024 18:05
@johnb432
Copy link
Contributor Author

johnb432 commented Sep 5, 2024

super-rare but clones can drown - (getOxygenRemaining drops) but I don't think it's a big deal, u really have to try to get them into this situation image

Mostly solved by refilling the oxygen from time to time (<0.5 seems to be lethal with the medical system). If you manually set the oxygen to 0, it's possible to have the unit die.

LinkIsGrim
LinkIsGrim approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't break it this time

@LinkIsGrim
Copy link
Contributor

Fuck it, we ball

@LinkIsGrim LinkIsGrim merged commit e2335c9 into acemod:master Sep 7, 2024
4 checks passed
@johnb432 johnb432 mentioned this pull request Sep 7, 2024
Closed
@johnb432 johnb432 deleted the corpse-carry-continued2 branch September 7, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas left review comments

@jokoho48 jokoho48 jokoho48 left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
10 participants
@johnb432 @PabstMirror @LinkIsGrim @BrettMayson @Drofseh @rautamiekka @jonpas @Dystopian @jokoho48 @BaerMitUmlaut