Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - SQF Improvements #9698

Merged
merged 19 commits into from
Feb 4, 2024
Merged

General - SQF Improvements #9698

merged 19 commits into from
Feb 4, 2024

Conversation

BrettMayson
Copy link
Member

@BrettMayson BrettMayson commented Dec 31, 2023 •
edited
Loading

When merged this pull request will:

  • Use [false, true] select (condition) when using constants, supposedly 35% faster
  • Don't use typeName on constants (only in included BI code)
  • Use str ... instead of format ["%1", ...]
  • Use parseNumber ... instead of [0, 1] select ...

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@BrettMayson BrettMayson changed the title Gemeral - Use select for ifs returning constants Gemeral - SQF Improvements Dec 31, 2023
@LinkIsGrim LinkIsGrim added the kind/optimization Release Notes: **IMPROVED:** label Dec 31, 2023
@BrettMayson BrettMayson changed the title Gemeral - SQF Improvements General - SQF Improvements Dec 31, 2023
@jonpas
Copy link
Member

jonpas commented Jan 7, 2024

I don't like that we are changing includes. HEMTT should have an option to ignore warnings in includes.

@BrettMayson @PabstMirror
Revert from suggestions from code review
9db1078 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror added this to the 3.16.4 milestone Jan 22, 2024
@LinkIsGrim LinkIsGrim merged commit 1e404cf into acemod:master Feb 4, 2024
5 checks passed
@BrettMayson BrettMayson deleted the sqf_if_select branch March 26, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dystopian Dystopian Dystopian requested changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BrettMayson @jonpas @Dystopian @PabstMirror @LinkIsGrim