Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory - Improve multiple aspects #9706

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Inventory - Improve multiple aspects #9706

merged 3 commits into from
Jan 6, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jan 1, 2024

When merged this pull request will:

  • Moved name-weight bar modification from ace_movement into ace_inventory.
  • Improved medical item detection.
  • Improved item filtering:
    • Now removes medical and face wear items from 'items' tab, as they have their own tabs (face wear is in the head gear tab).
    • Fixed an issue with a bad macro, making vests pop up in the 'items' tab when they shouldn't.
  • Closes Inventory weight doesn't work with subordinates #7150.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim
Copy link
Contributor

Medical should remain in item filter

@johnb432
Copy link
Contributor Author

johnb432 commented Jan 1, 2024

Medical should remain in item filter

You want medical items to remain the items tab, despite there being a dedicated tab for them? Feels unnecessary.
I added some clarification in the post.

@LinkIsGrim
Copy link
Contributor

Medical should remain in item filter

You want medical items to remain the items tab, despite there being a dedicated tab for them? Feels unnecessary.
I added some clarification in the post.

Yeap

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM

addons/inventory/initSettings.inc.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Jan 1, 2024
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Jan 1, 2024
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jan 5, 2024

Medical should remain in item filter

Fuck it, we'll just wait till someone complains about it

@jonpas
Copy link
Member

jonpas commented Jan 5, 2024

Medical items showing only in medical tab makes sense to me.

@rautamiekka
Copy link
Contributor

Medical should remain in item filter

You want medical items to remain the items tab, despite there being a dedicated tab for them? Feels unnecessary.
I added some clarification in the post.

Yeap

Weirdly arbitrary, ngl.

Medical items showing only in medical tab makes sense to me.

I mean, that's the whole point. 100% agree.

@LinkIsGrim LinkIsGrim merged commit 7f998c3 into master Jan 6, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the inventory-refactor branch January 6, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory weight doesn't work with subordinates
4 participants