Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laser - Public getter and setter for laser codes #9772

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Laser - Public getter and setter for laser codes #9772

merged 3 commits into from
Feb 7, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Feb 6, 2024 •
edited
Loading

When merged this pull request will:

  • Title.
  • We need to decide what should be returned if nothing is defined for the getter: Should the default code be returned or something like -1?

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 changed the title Laser - Public Getter and setter for laser codes Laser - Public getter and setter for laser codes Feb 6, 2024
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Feb 6, 2024
@LinkIsGrim LinkIsGrim added this to the 3.16.4 milestone Feb 6, 2024
@johnb432 johnb432 merged commit 28e45c2 into master Feb 7, 2024
5 checks passed
@johnb432 johnb432 deleted the laser-get-set branch February 7, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@BrettMayson BrettMayson BrettMayson approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @BrettMayson @LinkIsGrim