Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW - Delay init for CSW with simulation disabled #9778

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title. This is relevant for ZEN's placement preview feature, which breaks magazine unloading if advanced assembly is enabled.

simulationEnabled objNull is true so this handles the csw being deleted

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Feb 7, 2024
@LinkIsGrim LinkIsGrim added this to the 3.16.4 milestone Feb 7, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinkIsGrim LinkIsGrim merged commit 802560d into master Feb 7, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the csw-delay-init-until-simulationEnabled branch February 7, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants