Hearing - Keybind for putting or taking out earplugs #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the benefit in a keybind? |
|
IMO should be unassigned by default. |
Yeah. |
Like some other keybinds in ACE: It's more convenient and faster than going through the menu. Adding the possibility to bind a key to toggle earplugs doesn't impact the game in a negative way, imo, especially if it's left unbound by default. |
johnb432
changed the title
Thanks! |
Don't need to register keybinds on machines that don't have interfaces. Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Removed default keybind, added new line at the end of the file and changed some code formatting, as well as some functions: Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
approved these changes
Feb 27, 2024
PabstMirror
approved these changes
Feb 28, 2024
LinkIsGrim
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ALT+HunboundIMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.