Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parachute - Add Seconds Indicator to Altimeter Watch #9834

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Mar 7, 2024

When merged this pull request will:

  • Add seconds to the digital clock on the Altimeter Watch, changing its format to HH:MM:SS. Making it more useful for timing explosives or tracking artillery TOF accurately;

@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Mar 7, 2024
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Mar 7, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20240309101332_1
The right most digit's shadow is cut off.

@mrschick
Copy link
Contributor Author

mrschick commented Mar 9, 2024

Odd, I centered it more so that wouldn't happen and it looked ok, must have done something wrong then.

@mrschick
Copy link
Contributor Author

mrschick commented Mar 9, 2024

Looks different on my end 🤔
20240309142325_1

@PabstMirror
Copy link
Contributor

watch
Also a tiny bit cutoff for me
Probably no harm in just making the text rsc a bit wider if it's left aligned?

@mrschick
Copy link
Contributor Author

mrschick commented Mar 9, 2024

Also a tiny bit cutoff for me

It seems like it's drawing the entire rsc more to the right for both of you.

Probably no harm in just making the text rsc a bit wider if it's left aligned?

Done, looks fine to me again, though you should probably double check.

@mrschick
Copy link
Contributor Author

@johnb432 how did you get that debug window on the left of your screen?

@johnb432
Copy link
Contributor

@johnb432 how did you get that debug window on the left of your screen?

Advanced Developer Tools

@LinkIsGrim LinkIsGrim merged commit dd32190 into acemod:master Mar 10, 2024
5 checks passed
@mrschick mrschick deleted the feature/altimeter-seconds branch March 10, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants