Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Tools - Show GPS on Map when equipped with UAV Terminal #9885

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Map Tools - Show GPS on Map when equipped with UAV Terminal #9885

merged 8 commits into from
Apr 4, 2024

Conversation

mrschick
Copy link
Contributor

When merged this pull request will:

  • Show the GPS grid display on map when carrying a UAV Terminal, and not just the vanilla GPS item;
  • Rephrase maptools documentation accordingly;

rautamiekka
rautamiekka suggested changes Mar 28, 2024
View reviewed changes
docs/wiki/feature/maptools.md Outdated Show resolved Hide resolved
@mrschick @rautamiekka
Reword docs, remove dash
5ecff81 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@PabstMirror PabstMirror added this to the Ongoing milestone Mar 28, 2024
@PabstMirror PabstMirror added the kind/change Release Notes: **CHANGED:** label Mar 28, 2024
mrschick and others added 2 commits March 30, 2024 17:24
@mrschick @LinkIsGrim
Reword docs
f1fde75 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@mrschick @LinkIsGrim
Return statement - remove ; and add comment
15c81f6 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
johnb432
johnb432 approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to see if this has any negative side effects, but given the tests I'm fairly confident it won't have any.

@LinkIsGrim LinkIsGrim modified the milestones: Ongoing, 3.17.1 Apr 4, 2024
@LinkIsGrim LinkIsGrim merged commit ccb3e65 into acemod:master Apr 4, 2024
5 checks passed
@mrschick mrschick deleted the feature/mapgps-via-uavterminal branch April 4, 2024 15:31
@PabstMirror PabstMirror mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettMayson BrettMayson BrettMayson left review comments

@rautamiekka rautamiekka rautamiekka requested changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/change Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.17.1
Development

Successfully merging this pull request may close these issues.
6 participants
@mrschick @rautamiekka @BrettMayson @johnb432 @LinkIsGrim @PabstMirror