Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casings - Add CUP Casings #9888

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Casings - Add CUP Casings #9888

merged 1 commit into from
Apr 1, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Mar 30, 2024

When merged this pull request will:

  • Adds the 2 casings provided by CUP.

@Mike-MF Mike-MF added kind/enhancement Release Notes: **IMPROVED:** area/compatibility labels Mar 30, 2024
@Drofseh
Copy link
Contributor

Drofseh commented Mar 30, 2024

Does this not create a dependency?

@jonpas
Copy link
Member

jonpas commented Mar 30, 2024

No, it's dynamically spawned, and only if that cartridge was fired, which it can't if there is no CUP.

@veteran29
Copy link
Member

That whole mapping not being config based is quite meh IMO. Could use a refactor.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if model doesn't exist?

@jonpas
Copy link
Member

jonpas commented Apr 1, 2024

It's used by that casing, how could it not exist?

@jonpas jonpas added this to the 3.17.0 milestone Apr 1, 2024
@PabstMirror
Copy link
Contributor

result is cached, so we could do a fileExists check
but I agree that it should be safe as is,
a mod would have to be using CUP_FxCartridge_545 but not require cba_weapons

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Apr 1, 2024

It's used by that casing, how could it not exist?

Mod actually needs CUP but doesn't have it in requiredAddons, user doesn't load CUP -> model doesn't exist.
I can see this potentially happening for some of the weapon pack mods on the workshop.

But if arma vomits out an error before ACE does then it's fine I guess

@jonpas jonpas merged commit 0d45a85 into master Apr 1, 2024
5 checks passed
@jonpas jonpas deleted the casings-cup branch April 1, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compatibility kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants