-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casings - Add CUP Casings #9888
Conversation
Does this not create a dependency? |
No, it's dynamically spawned, and only if that cartridge was fired, which it can't if there is no CUP. |
That whole mapping not being config based is quite meh IMO. Could use a refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if model doesn't exist?
It's used by that casing, how could it not exist? |
result is cached, so we could do a |
Mod actually needs CUP but doesn't have it in requiredAddons, user doesn't load CUP -> model doesn't exist. But if arma vomits out an error before ACE does then it's fine I guess |
When merged this pull request will: