Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW - Fix CUP CSW #9907

Merged
merged 3 commits into from
Apr 2, 2024
Merged

CSW - Fix CUP CSW #9907

merged 3 commits into from
Apr 2, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 2, 2024

When merged this pull request will:

  • With only CBA, ACE and CUP Weapons loaded, the existing CSW config does not work.
    I didn't try if it worked if you have CUP Units and/or Vehicles loaded, as I made this fix independently from that.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Apr 2, 2024
@johnb432 johnb432 requested a review from Mike-MF April 2, 2024 17:10
Copy link
Member

@Mike-MF Mike-MF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably the worst person to review this, I have no idea what CSW is or how it works.

Although I now realise this should probably depend on Vehicles as the ace_csw_mortarBaseplate entries do come from there. Edit: Nevermind, they are in weapons, the file structure is just baffling.

Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as the weapons are real static weapons, this lgtm

Copy link
Member

@Mike-MF Mike-MF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the classes exist

@johnb432 johnb432 added this to the 3.17.1 milestone Apr 2, 2024
@johnb432 johnb432 merged commit 0375d0d into master Apr 2, 2024
5 checks passed
@johnb432 johnb432 deleted the csw-cup-metis-fix branch April 2, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants