-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interact Menu - Add nil
handling for condition
#9922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this if after #9876. Then this PR can break some 3rd party stuff (if any) where nil is returned in conditions. For BWC we should treat nil
return as true
instead. But I'm personally vote for PR as it is.
It's an error from the user, so imo BWC is not a concern here. |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
[] | ||
}; | ||
|
||
// Return nothing if the action is to far (including checking sub actions) [DISABLED FOR NOW ref #2196] | ||
// Return nothing if the action is too far (including checking sub actions) [DISABLED FOR NOW ref #2196] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes.
Big yikes.
When merged this pull request will:
nil
orbool
is returned, it will throw an error.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.