Medical Treatment - Only create litter on empty container #9924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
reviewed
Apr 5, 2024
| }; | ||
| case (_x in _unitMagazines): { | ||
| private _magsStart = count magazines _unit; |
There was a problem hiding this comment.
Do we need count? isNotEqualTo should be enough no?
There was a problem hiding this comment.
(count a) == (count b);
0.0004638 ms
a isEqualTo b;
0.0014113 ms
There was a problem hiding this comment.
Goddamn SQF just adding to the piling up pile of shit to test/remember for performance ... -.-
What about this ?
a isNotEqualTo [];There was a problem hiding this comment.
in this case a and b are both (possibly) large arrays, and it's only reason to use count here
array isEqualTo [] is still faster than count array == 0
I assume the first thing isEqualTo does is check the sizes are the same
LinkIsGrim
approved these changes
Apr 7, 2024
LinkIsGrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create pill boxes every time you take a single pill