Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Status - API to modify getBloodLoss #9926

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Conversation

BrettMayson
Copy link
Member

When merged this pull request will:

  • Title

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim
Copy link
Contributor

This won't actually modify return, no?

@LinkIsGrim
Copy link
Contributor

Need to do something like _eventArgs = [_unit, _loss], raise event with _eventArgs, then return _eventArgs select 1

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm biased, someone else look

@LinkIsGrim LinkIsGrim added this to the 3.17.1 milestone Apr 5, 2024
@LinkIsGrim
Copy link
Contributor

Tested, works

@LinkIsGrim LinkIsGrim merged commit f3f7f2c into master Apr 7, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the bloodloss_api branch April 7, 2024 01:18
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Apr 7, 2024
@jonpas jonpas changed the title Medical Status - API to modify getBloodLoss Medical Status - API to modify getBloodLoss Apr 7, 2024
MiszczuZPolski pushed a commit to KAT-Advanced-Medical/KAM that referenced this pull request May 23, 2024
**When merged this pull request will:**
- Modifies the event `ace_medical_status_getBloodLoss` to apply alpha
action factor
- Fixes a reference to alphaAction in circulation
- [ ] Requires acemod/ACE3#9926 to be released
- [ ] Requires #511 to be reverted

### IMPORTANT

- [Development Guidelines](https://ace3.acemod.org/wiki/development/)
are read, understood and applied.
- Title of this PR uses our standard template `Component -
Add|Fix|Improve|Change|Make|Remove {changes}`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants