-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Status - API to modify getBloodLoss
#9926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
This won't actually modify return, no? |
Need to do something like _eventArgs = [_unit, _loss], raise event with _eventArgs, then return _eventArgs select 1 |
LinkIsGrim
reviewed
Apr 5, 2024
LinkIsGrim
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm biased, someone else look
Tested, works |
jonpas
changed the title
Medical Status - API to modify getBloodLoss
Medical Status - API to modify Apr 7, 2024
getBloodLoss
MiszczuZPolski
pushed a commit
to KAT-Advanced-Medical/KAM
that referenced
this pull request
May 23, 2024
**When merged this pull request will:** - Modifies the event `ace_medical_status_getBloodLoss` to apply alpha action factor - Fixes a reference to alphaAction in circulation - [ ] Requires acemod/ACE3#9926 to be released - [ ] Requires #511 to be reverted ### IMPORTANT - [Development Guidelines](https://ace3.acemod.org/wiki/development/) are read, understood and applied. - Title of this PR uses our standard template `Component - Add|Fix|Improve|Change|Make|Remove {changes}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.