Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Treatment - Enforce bandage effectiveness variable type #9950

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • This would still throw an error, but at least the unit could be bandaged.

Experienced the following in a test mission:

16:37:04 Error in expression <ndage, _bodyPart, _bandageEffectiveness * ace_medical_treatment_bandageEffective>
16:37:04   Error position: <* ace_medical_treatment_bandageEffective>
16:37:04   Error *: Type Bool, expected Number,Not a Number
16:37:04 File /z/ace/addons/medical_treatment/functions/fnc_bandageLocal.sqf..., line 421
16:37:06 Ref to nonnetwork object 564990: <no shape>
16:37:19 Ref to nonnetwork object 565123: <no shape>
16:37:19 Error in expression <ndage, _bodyPart, _bandageEffectiveness * ace_medical_treatment_bandageEffective>
16:37:19   Error position: <* ace_medical_treatment_bandageEffective>
16:37:19   Error *: Type Bool, expected Number,Not a Number
16:37:19 File /z/ace/addons/medical_treatment/functions/fnc_bandageLocal.sqf..., line 421

I was in a heavily modded environment, so I don't think there is a way of finding out which mod is causing it. Not running KAT. I don't remember the context, so can't really give any info on that.
Only happened those two times, bandaging worked after that.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** ignore-changelog Release Notes: Excluded labels Apr 14, 2024
@johnb432 johnb432 added this to the 3.17.1 milestone Apr 14, 2024
@LinkIsGrim
Copy link
Contributor

How?

@johnb432
Copy link
Contributor Author

How?

You need to elaborate. How the error happened in the first place? I have no idea.

@johnb432 johnb432 merged commit dda6b9d into master Apr 16, 2024
5 checks passed
@johnb432 johnb432 deleted the bandage-effectiveness-enforce-return-type branch April 16, 2024 20:33
@tbeswick96
Copy link
Contributor

For me this just moves the error further up the chain ever so slightly

params ["_patient", "_bodyPart", "_banda>
22:33:02   Error position: <params ["_patient", "_bodyPart", "_banda>
22:33:02   Error Params: Type Bool, expected Number

I've replied to the discord thread where this has been reported previously

@jonpas jonpas removed the ignore-changelog Release Notes: Excluded label Apr 29, 2024
@CarlosRennier
Copy link

CarlosRennier commented Jun 2, 2024

I'm also having the same problem as johnb432 when I use the bandage. The error is the same: File /z/ace/addons/medical_treatment/functions/fnc_bandageLocal.sqf..., line 421

Can anyone help, please?

@LinkIsGrim
Copy link
Contributor

Make sure you're using 3.17.1. Open an issue with reproduction steps and RPT if the problem persists.

@CarlosRennier
Copy link

Certifique-se de estar usando 3.17.1. Abra um problema com etapas de reprodução e RPT se o problema persistir.

Sorry, but could you tell me how I do this?
Thanks!

@LinkIsGrim
Copy link
Contributor

https://github.com/acemod/ACE3/issues/new/choose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants