Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map - Use SlotItemChanged event #9961

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Map - Use SlotItemChanged event #9961

merged 6 commits into from
Oct 15, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** 2.18 labels Apr 20, 2024
@johnb432 johnb432 changed the title Map - Use slotItemChanged event Map - Use SlotItemChanged event May 28, 2024
@johnb432 johnb432 added kind/optimization Release Notes: **IMPROVED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels May 28, 2024
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jun 4, 2024 •
edited
Loading

Does this actually need 2.18? SlotItemChanged has been a thing since 2.14

@johnb432
Copy link
Contributor Author

johnb432 commented Jun 4, 2024

Does this actually need 2.18? SlotItemChanged has been a thing since 2.14

It's broken in 2.16 stable.

LinkIsGrim
LinkIsGrim approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.18

@johnb432 johnb432 mentioned this pull request Aug 31, 2024
Merged
@johnb432 johnb432 removed the 2.18 label Oct 9, 2024
@johnb432 johnb432 modified the milestones: 3.18.1, 3.18.2 Oct 9, 2024
@PabstMirror PabstMirror merged commit b23c657 into master Oct 15, 2024
8 checks passed
@PabstMirror PabstMirror deleted the map-use-slotitemevent branch October 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @LinkIsGrim @PabstMirror