New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hearing - Add earplugs only if not present #9987

Merged

johnb432 merged 1 commit into master from hearing-prevent-adding-earplugs-twice

Apr 28, 2024

Contributor

johnb432 commented Apr 28, 2024

When merged this pull request will:

Title.
In theory, if a unit's loadout in config would have earplugs, it would add a second pair because it would never check the unit's inventory. However, I haven't actually encountered this because I don't play with hearing enabled, so I don't know how necessary it is.

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.


          Only add earplugs if not present

01d1134

johnb432 added the kind/bug-fix label

BrettMayson approved these changes

View reviewed changes

johnb432 mentioned this pull request

Hearing - Improve and cleanup code #9933

Merged

johnb432 merged commit 6e32fc1 into master

5 checks passed

johnb432 deleted the hearing-prevent-adding-earplugs-twice branch

April 28, 2024 16:06

johnb432 added this to the 3.17.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels