Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookoff - Change cook-off fire damage #9991

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 28, 2024

When merged this pull request will:

  • Title.
    Increase damage, as current damage felt not severe enough.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/change Release Notes: **CHANGED:** label Apr 28, 2024
@johnb432 johnb432 mentioned this pull request Apr 28, 2024
@johnb432 johnb432 changed the title Fire - Increase cook-off fire damage Fire - Change cook-off fire damage Apr 28, 2024
@johnb432 johnb432 changed the title Fire - Change cook-off fire damage Cookoff - Change cook-off fire damage Apr 28, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone May 9, 2024
@johnb432 johnb432 merged commit 06f47e6 into master Jun 5, 2024
5 checks passed
@johnb432 johnb432 deleted the fire-cookoff-more-damage branch June 5, 2024 13:22
johnb432 added a commit to johnb432/ACE3 that referenced this pull request Jun 5, 2024
johnb432 added a commit that referenced this pull request Jun 5, 2024
* Cook-off improvements

* More changes

* Update fnc_getVehicleAmmo.sqf

* Better engine fire placement

* Update fnc_detonateAmmunition.sqf

* Update XEH_postInit.sqf

* Update fnc_getVehicleAmmo.sqf

* Update events-framework.md

* Various improvements

* Separate effect handling

* Tweaks

* Update XEH_postInit.sqf

* Prevent double ammo detonation

* Fixed objects not being able to cook-off again

* Added incendiary rounds as source of box cookoff

* Converted enable setting to bool

* Fixed brackets

* Update fnc_cookOff.sqf

* Update CfgEden.hpp

* Removed GVAR(enable), added GVAR(enableFire) back

* Update initSettings.inc.sqf

* Update events-framework.md

* Update addons/cookoff/functions/fnc_cookOffEffect.sqf

* Restructured, redid API events

* Fix effect for JIP, minor optimisations

* Removed `cbaSettings_settingChanged`

* Renamed variables, tweaked string table entries

* Update fire damage #9991

* Capitalize comments again

* Fix cookoff for very short durations and fix effect removal being too quick
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Cook-off improvements

* More changes

* Update fnc_getVehicleAmmo.sqf

* Better engine fire placement

* Update fnc_detonateAmmunition.sqf

* Update XEH_postInit.sqf

* Update fnc_getVehicleAmmo.sqf

* Update events-framework.md

* Various improvements

* Separate effect handling

* Tweaks

* Update XEH_postInit.sqf

* Prevent double ammo detonation

* Fixed objects not being able to cook-off again

* Added incendiary rounds as source of box cookoff

* Converted enable setting to bool

* Fixed brackets

* Update fnc_cookOff.sqf

* Update CfgEden.hpp

* Removed GVAR(enable), added GVAR(enableFire) back

* Update initSettings.inc.sqf

* Update events-framework.md

* Update addons/cookoff/functions/fnc_cookOffEffect.sqf

* Restructured, redid API events

* Fix effect for JIP, minor optimisations

* Removed `cbaSettings_settingChanged`

* Renamed variables, tweaked string table entries

* Update fire damage acemod#9991

* Capitalize comments again

* Fix cookoff for very short durations and fix effect removal being too quick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/change Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants