Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Field Rations - Add CBA events for consuming items and refilling bottles #159

Merged
merged 4 commits into from
Dec 28, 2018

Conversation

diwako
Copy link
Contributor

@diwako diwako commented Dec 15, 2018

When merged this pull request will:
Adds local CBA events when consuming items or refilling items.

Reason for this is, there is no way to interact with this so far on mission level. If someone wants to manipulate how much an item quenches thirst or how much hunger is sated it has to be done via mod right now.
This also means scripters can add their own logic when someone consumes a certain item or refills at a certain water source.

Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"refillItem" looks so weird :D

@diwako
Copy link
Contributor Author

diwako commented Dec 15, 2018

It is the functions name, so ¯_(ツ)_/¯

@jonpas
Copy link
Member

jonpas commented Dec 15, 2018

Those should probably be named corresponding to standard of name in other events here.

Eg. acex_rationConsumed and acex_rationRefilled.

@PabstMirror
Copy link
Contributor

I'm fine keeping these events, but we should probably just add settings for amount of thirst/hunger restored

@diwako
Copy link
Contributor Author

diwako commented Dec 16, 2018

Updated the event names to be named like other events in ace.

@PabstMirror PabstMirror added this to the 3.5.0 milestone Dec 16, 2018
@PabstMirror
Copy link
Contributor

Ref #160 for settings for thirst quench

Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about acex_itemConsumed and acex_itemRefilled?

@jonpas
Copy link
Member

jonpas commented Dec 16, 2018

That could be any item, and this is specific to rations. Just my opinion though.

@diwako
Copy link
Contributor Author

diwako commented Dec 16, 2018

Did i kill travis CI? The logs only return null.

@jonpas
Copy link
Member

jonpas commented Dec 16, 2018

Probably just a minor outage, I restarted the build.

@mharis001
Copy link
Member

What I was thinking as well for itemConsumed, I guess itemRefilled is more clear with that. Could QGVAR prefix them for field_rations?

@diwako
Copy link
Contributor Author

diwako commented Dec 16, 2018

In commit one I used QGVAR prefix on the event names, it was suggested to change them to be similar to ace's naming.

@mharis001
Copy link
Member

QGVAR solves the being specific to field rations problem. IMO itemRefilled is a better name than rationRefilled.

@diwako
Copy link
Contributor Author

diwako commented Dec 28, 2018

I am fine with either QGVARr or acex_* as they are now. Ultimately the maintainers of this mod have to decide this.

Copy link
Contributor

@thojkooi thojkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thojkooi thojkooi merged commit bd255de into acemod:master Dec 28, 2018
@thojkooi
Copy link
Contributor

Thanks @diwako

@dedmen
Copy link
Contributor

dedmen commented Mar 8, 2019

Typo in title.
refilling not re-filing aka file.

@bux bux changed the title Field Rations - Add CBA events for consuming items and refiling bottles Field Rations - Add CBA events for consuming items and refilling bottles Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants