-
Notifications
You must be signed in to change notification settings - Fork 42
Field Rations - Add CBA events for consuming items and refilling bottles #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"refillItem" looks so weird :D
It is the functions name, so ¯_(ツ)_/¯ |
Those should probably be named corresponding to standard of name in other events here. Eg. |
I'm fine keeping these events, but we should probably just add settings for amount of thirst/hunger restored |
Updated the event names to be named like other events in ace. |
Ref #160 for settings for thirst quench |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about acex_itemConsumed
and acex_itemRefilled
?
That could be any item, and this is specific to rations. Just my opinion though. |
Did i kill travis CI? The logs only return |
Probably just a minor outage, I restarted the build. |
What I was thinking as well for |
In commit one I used |
|
I am fine with either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @diwako |
Typo in title. |
When merged this pull request will:
Adds local CBA events when consuming items or refilling items.
Reason for this is, there is no way to interact with this so far on mission level. If someone wants to manipulate how much an item quenches thirst or how much hunger is sated it has to be done via mod right now.
This also means scripters can add their own logic when someone consumes a certain item or refills at a certain water source.