Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Intel Items - Fix addIntel addMagazine locality #225

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

shukari
Copy link
Contributor

@shukari shukari commented Mar 11, 2020

When merged this pull request will:

@mharis001
Copy link
Member

Interestingly magazinesDetail reports as if a magazine was added, even though it failed.

@mharis001 mharis001 changed the title IntelItems - Fix addIntel Intel Items - Fix addIntel addMagazine locality Mar 11, 2020
@mharis001 mharis001 added this to the 3.6.0 milestone Mar 11, 2020
Co-Authored-By: mharis001 <34453221+mharis001@users.noreply.github.com>
@dedmen
Copy link
Contributor

dedmen commented Mar 11, 2020

Interestingly magazinesDetail reports as if a magazine was added, even though it failed.

feedback tracker ticket if you want that fixed.

@shukari
Copy link
Contributor Author

shukari commented Mar 11, 2020

Interestingly magazinesDetail reports as if a magazine was added, even though it failed.

feedback tracker ticket if you want that fixed.

addMagazine adds the magazin to the object but only on the server (or where it gets executed)... so if you do magazines on the server it is more than on the object (in this case the player) has

[] spawn {
    private _return = []; 
    _return pushBack (count (magazines player));
    [player, {
        private _return = []; 
        _return pushBack (count (magazines _this));
        _this addmagazine "acex_intelitems_notepad";
        _return pushBack (count (magazines _this));
        (format ["MagazineServer: %1", _return] remoteExecCall ["systemChat"]);
    }] remoteExecCall ["call", 2];
    uiSleep 1;
    _return pushBack (count (magazines player));
    (format ["MagazineClient: %1", _return] remoteExecCall ["systemChat"]);
};

MagazineServer: [8,9]
MagazineClient: [8,8]

if you execute this multiple times the server has x more ^^

@mharis001 mharis001 merged commit 33cb84e into acemod:master Mar 11, 2020
@dedmen
Copy link
Contributor

dedmen commented Mar 11, 2020

adds the magazin to the object but only on the server

Ah not a bug then, thanks.

@shukari shukari deleted the fixAddIntel branch March 11, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants