[SQL] Removed insertion or updates in mri_acquisition_dates #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycAbout
approved these changes
Jul 22, 2019
driusan
pushed a commit
to aces/Loris
that referenced
this pull request
Jul 30, 2019
…ORIS code (#4962) This removes the mri_acquisition_dates table from the database as this table does not necessarily store the correct acquisition date. Instead, replaced all the queries to look for the minimal date present in the parameter_file table which is more robust than what was stored in mri_acquisition_dates. Note: the decision to remove this table was taken during an imaging meeting in 2017 and confirmed at an other imaging meeting in 2019. See also aces/Loris-MRI#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The associated PR aces/Loris#4962 on the LORIS side removes the
mri_acquisition_datestable from the database as this table does not necessarily store the correct acquisition date. Instead, replaced all the queries to look for the minimal date present in theparameter_filetable which is more robust than what was stored in mri_acquisition_dates.Note: the decision to remove this table was taken during an imaging meeting in 2017 and confirmed at an other imaging meeting in 2019.
Links to related tickets (Github, Redmine, ...)
https://redmine.cbrain.mcgill.ca/issues/6040