-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PET HRRT insertion pipeline #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Add to release notes
New Feature
Needs Work Before Merging
Blocked
Merge it and you die
Update PerlDoc or Documentation
labels
Feb 27, 2020
…ils, out of memory...
minc_insertion.pl -profile prod -mincPath/data/incoming/preventAD/MTL0661_603347_PREPT00_NAV_small/MTL0661_603347_PREPT00-NAV-HRRT1030-2017.3.16.12.3.14_EMMASK_3D.mnc -acquisition_protocol F18NAV6frOSEM -bypass_extra_file_checks Then need to: - find a way to link the ecat data in parameter file - call mass_pic.pl - call mass_jiv.pl - implement an ImagingUpload function that calls HRRT_PET_insertion.pl with proper argument (included set BIC flag) - proper logging and exit codes - clean up the todo item modified: HRRT_PET_insertion.pl modified: NeuroDB/HRRTSUM.pm
Inserting MINC file from HRRT scanner into the database minc_insertion.pl working. Left to add a link from files to hrrt_archive. SQL modified, need to modify the scripts in consequence. Adding HrrtArchiveID into the files table and adding a link to the ecat file into the parameter_file table Making that all call to modified functions with upload_id instead of archive source location are modified to include $upload_id Instead of using getUploadIDUsingTarchiveSrcLoc for all functions of MRIProcessingUtility, passing the uploadID to those functions to simplify the code Update hrrt_archive and mri_upload tables at the end of HRRT_PET_insertion.pl execution Fixed a conflict badly resolved and uncommented big part of the script that were commented for testing A few more changes to the HRRT_PET_insertion.pl script incorporating the exit codes into the PET pipeline Fixing one of the exit code and adding description for the new script Removed columns from hrrt_archive and modified hash technic from MD5 to BLAKE2 Changed the way we identify the uploaded study is from an HRRT scanner Removed the modality from the Schema changes Fixing the exit codes for imaging_upload_file.pl and ImagingUpload.pm Solved exit code duplication, removed extra print and change mod of HRRT_PET_insertion.pl so can be called from imaging_upload_file.pl remove unrelated changes due to rebase remove unrelated changes due to rebase cleanup finished cleanup of rebase hopefully finished cleanup of rebase hopefully moved some functions to HRRT a few improvements modifed the profileTemplate.pl fixed a bug in mri_upload update fix bug in imaging upload fixed a few bugs
cmadjar
force-pushed
the
PetHrrtInsertion_rebase
branch
from
March 9, 2020 15:55
ebbf24b
to
dd627d2
Compare
driusan
pushed a commit
to aces/Loris
that referenced
this pull request
Jul 21, 2020
…6142) This updates the SQL schema to include the new PET HRRT archive tables and their link to the already existing imaging tables for Loris-MRI. See also: aces/Loris-MRI#524, aces/Loris-MRI#480
spell00
pushed a commit
to spell00/Loris
that referenced
this pull request
Aug 13, 2020
…ces#6142) This updates the SQL schema to include the new PET HRRT archive tables and their link to the already existing imaging tables for Loris-MRI. See also: aces/Loris-MRI#524, aces/Loris-MRI#480
laemtl
force-pushed
the
PetHrrtInsertion_rebase
branch
from
February 19, 2021 19:14
cebbf46
to
154608e
Compare
PrrPet hrrt insertion rebase
PetHRRT pipeline fixes (#2)
laemtl
approved these changes
Feb 24, 2021
I tested the PET pipeline with success. |
PetHRRT pipeline fixes (v3)
PetHRRT pipeline fixes (v4)
…me values from the mincheader...
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 15, 2021
…ces#6142) This updates the SQL schema to include the new PET HRRT archive tables and their link to the already existing imaging tables for Loris-MRI. See also: aces/Loris-MRI#524, aces/Loris-MRI#480
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
…ces#6142) This updates the SQL schema to include the new PET HRRT archive tables and their link to the already existing imaging tables for Loris-MRI. See also: aces/Loris-MRI#524, aces/Loris-MRI#480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New dependencies:
Note for projects using the MNI HRRT PET scanner:
If you are acquiring datasets using the MNI HRRT PET scanner, ensure that:
HRRT_PET_insertion.pl
, the option-bic
. Note, the flag is automatically set on the call toHRRT_PET_insertion.pl
fromimaging_upload_file.pl
based on the number of files that contains theBIC
string for the moment.prod
, seedicom-archive/profileTemplate.pl
for example)mri_scan_type
based on the information present in thePROTOCOL
variable of the Matlab file of the BIC HRRT study. Example: for an acquisition acquired using thePROTOCOL
F18_NAV_6fr
the following scan types need to be created based on the reconstruction technique (OSEM or FBP) and whether motion correction was applied to the image or not:F18NAV6frOSEM
: OSEM (Ordered Suspect Expectation Maximization) reconstructionF18NAV6frFBP
: FBP (Filter Back Projection) reconstructionF18NAV6frOSEMmc
: OSEM reconstruction and motion correction appliedF18NAV6frFBPmc
: FBP reconstruction and motion correction appliedIssues and link to other PRs