[API] add Incomplete tests markers - correct travis errors

aces · Jul 9, 2020 · 5ec04bc · 5ec04bc
1 parent 114a026
commit 5ec04bc
Show file tree

Hide file tree

Showing 5 changed files with 82 additions and 45 deletions.
diff --git a/modules/api/test/LorisApiDicomsTest.php b/modules/api/test/LorisApiDicomsTest.php
@@ -236,8 +236,10 @@ public function testPostCandidatesCandidVisitDicoms(): void
             ]
         );
         if ($response->getStatusCode() === 405) {
-            $this->markTestIncomplete("The method POST is not available for the" .
-            "endpoint candidates/$this->candidTest/$this->visitTest/dicoms");
+            $this->markTestIncomplete(
+                "The method POST is not available for the" .
+                "endpoint candidates/$this->candidTest/$this->visitTest/dicoms"
+            );
         }
         // Verify the status code - TODO METHOD NOT ALLOWED YET
         $this->assertEquals(200, $response->getStatusCode());
@@ -262,10 +264,11 @@ public function testGetCandidatesCandidVisitDicomsTarname(): void
             [
                 'headers'     => $this->headers,
                 'http_errors' => false
-           ]
+            ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/dicoms "
             );
         }
@@ -274,16 +277,16 @@ public function testGetCandidatesCandidVisitDicomsTarname(): void
         $body = $response->getBody();
         $this->assertNotEmpty($body);
 
-        $resource = fopen($this->tarfileTest, 'w');
-        $stream = GuzzleHttp\Psr7\stream_for($resource);
+        $resource        = fopen($this->tarfileTest, 'w');
+        $stream          = GuzzleHttp\Psr7\stream_for($resource);
         $response_stream = $this->client->request(
             'GET',
             "candidates/$this->candidTest/$this->visitTest/dicoms/" .
             "$this->tarfileTest",
             [
                 'http_errors' => false,
-                'headers' => $this->headers,
-                'save_to' => $stream,
+                'headers'     => $this->headers,
+                'save_to'     => $stream,
             ]
         );
         $this->assertEquals(200, $response_stream->getStatusCode());
@@ -294,7 +297,8 @@ public function testGetCandidatesCandidVisitDicomsTarname(): void
         $this->assertFileIsReadable($this->tarfileTest);
     }
 
-    // THESE ENDPOINTS DO NOT EXIST YET, this is why the tests assert the response is 404
+    // THESE ENDPOINTS DO NOT EXIST YET, this is why the tests assert
+    // the response is 404
 
     /**
      * Tests the HTTP GET request for the
@@ -314,7 +318,8 @@ public function testGetCandidatesCandidVisitDicomsTarnameProcesses(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/dicoms "
             );
         }
@@ -344,9 +349,11 @@ public function testGetCandidatesCandidVisitDicomsTarnameProcessesProcessid():
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/dicoms "
             );
+        }
         $this->assertEquals(200, $response->getStatusCode());
         // Verify the endpoint has a body
         $body = $response->getBody();

diff --git a/modules/api/test/LorisApiImagesTest.php b/modules/api/test/LorisApiImagesTest.php
@@ -117,7 +117,8 @@ public function testGetCandidatesCandidVisitImagesFilename(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/images/" .
                 "$this->imagefileTest"
             );
@@ -134,7 +135,7 @@ public function testGetCandidatesCandidVisitImagesFilename(): void
             "candidates/$this->candidTest/$this->visitTest/images/" .
             "$this->imagefileTest",
             [
-                'headers' => $this->headers,
+                'headers'     => $this->headers,
                 'http_errors' => false,
             ]
         );
@@ -347,7 +348,8 @@ public function testGetCandidatesCandidVisitImagesFilenameFormatBbrowser(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/images/" .
                 "$this->imagefileTest/format/brainbrowser"
             );
@@ -441,7 +443,8 @@ public function testGetCandidatesCandidVisitImagesFilenameFormatRaw(): void
                 ]
             );
             if ($response->getStatusCode() === 404) {
-                $this->markTestIncomplete("Endpoint not found: " .
+                $this->markTestIncomplete(
+                    "Endpoint not found: " .
                     "candidates/$this->candidTest/$this->visitTest/images/" .
                     "$this->imagefileTest/format/raw"
                 );
@@ -472,13 +475,14 @@ public function testGetCandidatesCandidVisitImagesFilenameFormatThumbnail():
             "candidates/$this->candidTest/$this->visitTest/images/" .
             "$this->imagefileTest/format/thumbnail",
             [
-                'headers' => $this->headers,
+                'headers'     => $this->headers,
                 'http_errors' => false,
-                'save_to' => $stream
+                'save_to'     => $stream
             ]
         );
-        if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+        if ($response_stream->getStatusCode() === 404) {
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/images/" .
                 "$this->imagefileTest/format/thumbnail"
             );
@@ -509,7 +513,8 @@ public function testGetCandidatesCandidVisitImagesFilenameHeaders(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/images/" .
                 "$this->imagefileTest/headers"
             );
@@ -752,7 +757,8 @@ public function testGetCandidatesCandidVisitImagesFilenameHeadersFull(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/images/" .
                 "$this->imagefileTest/headers/full"
             );
@@ -839,7 +845,8 @@ public function testGetCandidatesCandidVisitImagesFilenameHeadersHeadername():
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/images/" .
                 "$this->imagefileTest/headers/headername"
             );

diff --git a/modules/api/test/LorisApiInstrumentsTest.php b/modules/api/test/LorisApiInstrumentsTest.php
@@ -59,7 +59,8 @@ public function testGetCandidatesCandidVisitInstruments(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/instruments"
             );
         }
@@ -161,7 +162,8 @@ public function testGetCandidatesCandidVisitInstrumentsInstrument(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: " .
+            $this->markTestIncomplete(
+                "Endpoint not found: " .
                 "candidates/$this->candidTest/$this->visitTest/instruments/" .
                 "$this->instrumentTest"
             );
@@ -291,7 +293,8 @@ public function testPatchCandidatesCandidVisitInstrumentsInstrument(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: PATCH" .
+            $this->markTestIncomplete(
+                "Endpoint not found: PATCH" .
                 "candidates/$candid/$visit/instruments/$instrument"
             );
         }
@@ -333,7 +336,8 @@ public function testPutCandidatesCandidVisitInstrumentsInstrument(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: PUT" .
+            $this->markTestIncomplete(
+                "Endpoint not found: PUT" .
                 "candidates/$candid/$visit/instruments/$instrument"
             );
         }
@@ -361,7 +365,8 @@ public function testGetCandidatesCandidVisitInstrumentsInstrumentFlags(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/instruments/" .
                 "$this->instrumentTest/flags"
             );
@@ -469,7 +474,8 @@ public function testPatchCandidatesCandidVisitInstrumentsInstrumentFlags(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: PATCH" .
+            $this->markTestIncomplete(
+                "Endpoint not found: PATCH" .
                 "candidates/$candid/$visit/instruments/$instrument/flags"
             );
         }
@@ -511,7 +517,8 @@ public function testPutCandidatesCandidVisitInstrumentsInstrumentFlags(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: PUT" .
+            $this->markTestIncomplete(
+                "Endpoint not found: PUT" .
                 "candidates/$candid/$visit/instruments/$instrument/flags"
             );
         }
@@ -539,8 +546,10 @@ public function testGetCandidatesCandidVisitInstrumentsInstrumentDde(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
-                "candidates/$candid/$visit/instruments/$instrument/dde"
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
+                "candidates/$this->candidTest/$this->visitTest/instruments/" .
+                "$this->instrumentTest/dde"
             );
         }
         $this->assertEquals(200, $response->getStatusCode());
@@ -663,7 +672,8 @@ public function testPatchCandidatesCandidVisitInstrumentsInstrumentDde(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: PATCH" .
+            $this->markTestIncomplete(
+                "Endpoint not found: PATCH" .
                 "candidates/$candid/$visit/instruments/$instrument/dde"
             );
         }
@@ -705,7 +715,8 @@ public function testPutCandidatesCandidVisitInstrumentsInstrumentDde(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: PUT" .
+            $this->markTestIncomplete(
+                "Endpoint not found: PUT" .
                 "candidates/$candid/$visit/instruments/$instrument/dde"
             );
         }
@@ -735,7 +746,8 @@ public function testGetCandidatesCandidVisitInstrumentsInstrumentDdeFlags():
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/instruments/
             $this->instrumentTest/dde/flags"
             );
@@ -843,7 +855,8 @@ public function testPatchCandidVisitInstrumentsInstrumentDdeFlags(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$candid/$visit/instruments/$instrument/dde/flags",
             );
         }
@@ -885,7 +898,8 @@ public function testPutCandidVisitInstrumentsInstrumentDdeFlags(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$candid/$visit/instruments/$instrument/dde/flags",
             );
         }

diff --git a/modules/api/test/LorisApiProjectsTest.php b/modules/api/test/LorisApiProjectsTest.php
@@ -541,7 +541,8 @@ public function testGetProjectsProjectInstrumentsInstrument(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "projects/$this->projectIdTest/instruments/aosi",
             );
         }

diff --git a/modules/api/test/LorisApiRecordingsTest.php b/modules/api/test/LorisApiRecordingsTest.php
@@ -61,7 +61,8 @@ public function testGetCandidatesCandidVisitRecordings(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/"
             );
         }
@@ -133,7 +134,8 @@ public function testGetCandidatesCandidVisitRecordingsEdffile(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest"
             );
@@ -164,7 +166,8 @@ public function testGetCandidatesCandidVisitRecordingsEdffileChannels(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest/channels"
             );
@@ -353,7 +356,8 @@ public function testGetCandidatesCandidVisitRecordingsEdffileChannelsMeta():
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest/channels/meta"
             );
@@ -541,7 +545,8 @@ public function testGetCandidatesCandidVisitRecordingsEdfFileElectrodes(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest/electrodes"
             );
@@ -688,7 +693,8 @@ public function testGetCandidatesCandidVisitRecordingsEdfFileElectrodesMeta():
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest/electrodes/meta"
             );
@@ -834,7 +840,8 @@ public function testGetCandidatesCandidVisitRecordingsEdfFileEvents(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest/events/meta"
             );
@@ -980,7 +987,8 @@ public function testGetCandidatesCandidVisitRecordingsEdfFileEventsMeta(): void
             ]
         );
         if ($response->getStatusCode() === 404) {
-            $this->markTestIncomplete("Endpoint not found: GET" .
+            $this->markTestIncomplete(
+                "Endpoint not found: GET" .
                 "candidates/$this->candidTest/$this->visitTest/recordings/" .
                 "$this->frecordTest/events/meta"
             );