Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstan to static analysis test suite #5356

Closed
johnsaigle opened this issue Oct 22, 2019 · 3 comments
Closed

Add phpstan to static analysis test suite #5356

johnsaigle opened this issue Oct 22, 2019 · 3 comments
Labels
Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed Testing PR contains test plan or automated test code (or config files for Travis)

Comments

@johnsaigle
Copy link
Contributor

PHPStan is another cool static analysis tool. It found a bunch of issues in #4928 and it would be good to add it to our suite.

@johnsaigle johnsaigle added Testing PR contains test plan or automated test code (or config files for Travis) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered labels Oct 22, 2019
@johnsaigle
Copy link
Contributor Author

Blocked until PHPUnit is upgraded in #5351 or #4433 as version >= 7 is required.

@johnsaigle johnsaigle added PR sent and removed State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed labels Oct 29, 2019
@johnsaigle
Copy link
Contributor Author

#4928 Adds phpstan to the repository

@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Development

No branches or pull requests

1 participant