Add strict type coding standard #6039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Feature
johnsaigle
commented
Feb 10, 2020
johnsaigle
added
the
State: Blocked
|
Blocked by #5356. Otherwise, when I try to update the |
|
#5356 is an issue (which I think is already resolved and needs to be closed?) |
johnsaigle
added
State: Needs rebase
cmadjar
added
the
State: Needs rebase
driusan
requested changes
Jun 15, 2020
|
|
||
| <rule ref="SlevomatCodingStandard.TypeHints.LongTypeHints"/> | ||
|
|
||
| <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing"/> |
There was a problem hiding this comment.
What does this have to do with enforcing strict types?
There was a problem hiding this comment.
It makes the spacing of type hints consistent. More of an aesthetic thing. Do you want me to remove it?
There was a problem hiding this comment.
If it's already passing and didn't require any changes I guess it's fine, but the PR title says it's for adding strict_type.
|
|
||
| <rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/> | ||
|
|
||
| <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/> |
johnsaigle
removed
the
State: Needs rebase
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Previous attempts to force type hints or strict typing en masse have failed because it's just too darn complicated to do it all at once.
This introduces a new Strict Type coding standard that we can selectively apply to files by adding to an array in test/run-php-linter.sh. Hopefully this will provide an approach to using stricter typing that is easier to author and review.
Using vendor/bin/phpcbf --standard=test/StrictTypesCS.xml $file will now allow PHPCBF to automatically provide
return types
param types
strict_types =1
based on PHPDocs.
It will also throw errors if Traversable types do not have specific type annotations.
The Database.class.inc file has been modified as an example of the changes
Resolves aces#5342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Previous attempts to force type hints or strict typing en masse have failed because it's just too darn complicated to do it all at once.
This introduces a new Strict Type coding standard that we can selectively apply to files by adding to an array in
test/run-php-linter.sh. Hopefully this will provide an approach to using stricter typing that is easier to author and review.Using
vendor/bin/phpcbf --standard=test/StrictTypesCS.xml $filewill now allow PHPCBF to automatically providebased on PHPDocs.
It will also throw errors if Traversable types do not have specific type annotations.
The Database.class.inc file has been modified as an example of the changes
Related
Resolves #5342