Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc Repo] Can't access the module with only the "Doc Repo delete" permission #6373

Closed
johnsaigle opened this issue Apr 14, 2020 · 2 comments · Fixed by #6331, #5234 or #6646
Closed

[Doc Repo] Can't access the module with only the "Doc Repo delete" permission #6373

johnsaigle opened this issue Apr 14, 2020 · 2 comments · Fixed by #6331, #5234 or #6646
Assignees
Labels
Category: Bug PR or issue that aims to report or fix a bug

Comments

@johnsaigle
Copy link
Contributor

These lines in the module need to be updated to also grant access to a user with the delete permission.

public function hasAccess(\User $user) : bool
{
return parent::hasAccess($user) &&
$user->hasPermission('document_repository_view');
}

I tested this and just having the "Delete files in Document Repository" does not seem to grant access to the module.

Originally posted by @pierre-p-s in #6331

@johnsaigle johnsaigle added 23.0.0-testing Category: Bug PR or issue that aims to report or fix a bug labels Apr 14, 2020
@ridz1208 ridz1208 linked a pull request Apr 15, 2020 that will close this issue
1 task
@johnsaigle johnsaigle reopened this Apr 27, 2020
@johnsaigle
Copy link
Contributor Author

#6331 was linked to close this PR but that PR does not solve the issue.

@ridz1208
Copy link
Collaborator

@johnsaigle the PR linked is going to master. I will remove the 23 label from this issue accordingly

driusan pushed a commit that referenced this issue Jul 8, 2020
-  Use the new File Uploader class to do file uploading.
- Add a new permission document_repository_edit to separate view and edit permissions.
- Cleanup files class in the doc repo module

    Resolves #4854
    Resolves #6373
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
-  Use the new File Uploader class to do file uploading.
- Add a new permission document_repository_edit to separate view and edit permissions.
- Cleanup files class in the doc repo module

    Resolves aces#4854
    Resolves aces#6373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
3 participants