Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] The endpoint /candidates/{candid}/{visit}/instruments/{instrument}/flags needs methods to handle PUT and PATCH requests #6777

Closed
spell00 opened this issue Jun 29, 2020 · 0 comments · Fixed by #6780
Closed

[API] The endpoint /candidates/{candid}/{visit}/instruments/{instrument}/flags needs methods to handle PUT and PATCH requests #6777

spell00 opened this issue Jun 29, 2020 · 0 comments · Fixed by #6780
Labels
Area: API PR or issue related to the API Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered

Comments

@spell00
Copy link
Contributor

spell00 commented Jun 29, 2020

Is your feature request related to an existing module?
The feature is related to the API. The endpoint /candidates/{candid}/{visit}/instruments/{instrument}/flags allows for GET, PUT and PATCH requests, but the methods to handle PUT and PATCH requests are not implemented.

Describe the solution you'd like
They should be implemented in modules/api/candidate/visit/instrument/flags.class.inc
@spell00 spell00 added the Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered label Jun 29, 2020
@johnsaigle johnsaigle added the Area: API PR or issue related to the API label Jun 29, 2020
@spell00 spell00 mentioned this issue Jun 29, 2020
Merged
driusan pushed a commit that referenced this issue Nov 9, 2020
@spell00
[API] PUT and PATCH methods added to Candidates visit/instruments/fla…
920fd4e 
…gs (#6780)

The methods handlePUT and handlePATCH were added to the endpoint /candidates/<candid>/<visit>/instruments/<instrument>.

    Resolves #6777
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
@spell00 @AlexandraLivadas
[API] PUT and PATCH methods added to Candidates visit/instruments/fla…
9ec7bed 
…gs (aces#6780)

The methods handlePUT and handlePATCH were added to the endpoint /candidates/<candid>/<visit>/instruments/<instrument>.

    Resolves aces#6777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: API PR or issue related to the API Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[API] PUT and PATCH methods added to Candidates visit/instruments/flags spell00/Loris
2 participants
@johnsaigle @spell00