Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRI violation drop down saved with no feedback #8441

Closed
cmadjar opened this issue Mar 14, 2023 · 2 comments · Fixed by #8442
Closed

MRI violation drop down saved with no feedback #8441

cmadjar opened this issue Mar 14, 2023 · 2 comments · Fixed by #8442
Assignees
@driusan
Labels
Category: Bug PR or issue that aims to report or fix a bug Critical to release PR or issue is key for the release to which it has been assigned
Milestone
25.0.0

Comments

@cmadjar
Copy link
Collaborator

cmadjar commented Mar 14, 2023

Describe the bug

Before the reactification of the MRI violation module, there used to be a save button that the user would click on to save the resolution status. Right now, the user has no feedback that the data will be saved from the dropdown selection.

Discussed either adding a save button or some kind of feedback to the user and updates to the Resolution Status column with the saved results.
@cmadjar cmadjar added the Category: Bug PR or issue that aims to report or fix a bug label Mar 14, 2023
@cmadjar cmadjar added this to the 25.0.0 milestone Mar 14, 2023
@cmadjar cmadjar added the Critical to release PR or issue is key for the release to which it has been assigned label Mar 14, 2023
@cmadjar
Copy link
Collaborator Author

cmadjar commented Mar 14, 2023

@driusan when you have a fix, feel free to assign the PR to me and I will be happy to test the changes. Thank you so much!

@cmadjar
Copy link
Collaborator Author

cmadjar commented Mar 14, 2023 •
edited
Loading

Comment from @SantiagoTG on #8399:

With regards to the setting the 'Resolution status':

Currently there is no 'Save' button, which means that any selection done is the final selection done for a given image file once the page is closed or refreshed. This is not ideal for two reasons:

  1. It may not be cleat to the user what to do to set the 'Resolution status', leaving the user to figure it out which can lead to naively changing a resolution status thinking nothing will be changed and closing or refreshing the page, leading to erroneous entries.
  2. If the user is scrolling around and inadvertently clicks on a dropdown and changes the setting, the moment you close the page or refresh it, you have no way of reverting the change. This is in opposition to being able to click 'Save', where you confirm or commit to any changes made, giving the user time to review and confirm these (it denotes intention to modify the entries). Thus, having the 'Save' button would be more intuitive and safe.

@driusan driusan mentioned this issue Mar 14, 2023
Merged
driusan added a commit that referenced this issue Mar 14, 2023
@driusan
[mri_violations] Provide feedback on resolution status change (#8442)
37e3019 
There is currently no feedback to the user when they change the
resolution status of a violation that something has changed, which
can be confusing.

This fades the table cell to green after the cell has been changed
in the same way that the conflict resolver does, so that the user
is aware that something happened.

Green is probably not the ideal colour, but is consistent with the
conflict resolver.

Fixes #8441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driusan driusan

Labels
Category: Bug PR or issue that aims to report or fix a bug Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Milestone
25.0.0
Development

Successfully merging a pull request may close this issue.

[mri_violations] Provide feedback on resolution status change driusan/Loris
2 participants
@driusan @cmadjar