Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[behavioural_qc] New Profile-level feedback not showing up in the Feedback table #9138

Closed
AlexandraLivadas opened this issue Mar 14, 2024 · 0 comments · Fixed by #9192
Closed

[behavioural_qc] New Profile-level feedback not showing up in the Feedback table #9138

AlexandraLivadas opened this issue Mar 14, 2024 · 0 comments · Fixed by #9192
Assignees
@CamilleBeau
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Category: Bug PR or issue that aims to report or fix a bug

Comments

@AlexandraLivadas
Copy link
Contributor

When a new Candidate Profile feedback thread is created, it does not appear in the Behavioural Feedback table (but it is properly created and visible on the Profile page). Note that there are no Profile-level feedbacks listed in that table at all, but this could just be that Raisinbread does not have any pre-existing ones.

@charliehenrib pointed out this bug in February in a comment of #8037, but I thought I'd make a separate issue to highlight this!

To Reproduce

  1. Go to a candidate's profile page (that your user has Site permissions for)
  2. Create a behavioural feedback thread (by clicking on the bvl_feedback module in the top right of the page)
  3. Re-load the page to ensure it was properly created
  4. Go to the Behavioural Quality Control module and the Behavioural Feedback tab
  5. See that the new thread is not listed here
@AlexandraLivadas AlexandraLivadas added Category: Bug PR or issue that aims to report or fix a bug 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Mar 14, 2024
@CamilleBeau CamilleBeau mentioned this issue Apr 4, 2024
Merged
1 task
driusan pushed a commit that referenced this issue Apr 11, 2024
@CamilleBeau
[Behavioural_QC] Display profile level feedbacks (#9192)
23dbe45 
This  changes the query for the behavioural feedback tab of the Behavioural QC module to use "LEFT JOIN" instead of "JOIN" on visit specific tables so that profile level feedbacks that do not relate to any visit will be displayed.

COALESCE function is used for the project and site fields to take the visit project / site if it exists, and the candidate project / site otherwise.

Resolves #9138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CamilleBeau CamilleBeau

Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Behavioural_QC] Display profile level feedbacks CamilleBeau/Loris
3 participants
@jeffersoncasimir @AlexandraLivadas @CamilleBeau