Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imaging Browser: Add Caveat flag for session table: Redmine 6039 #2135

Merged
merged 4 commits into from
Sep 9, 2016
Merged

Imaging Browser: Add Caveat flag for session table: Redmine 6039 #2135

merged 4 commits into from
Sep 9, 2016

Conversation

MounaSafiHarab
Copy link
Contributor

@MounaSafiHarab MounaSafiHarab commented Aug 18, 2016 •
edited
Loading

  • Added Caveat button (True/False; default is False) in imaging browser
  • Caveat column in session table
    redmine6039

@MounaSafiHarab MounaSafiHarab added Release: Add to release notes PR whose changes should be highlighted in the release notes Category: Feature PR or issue that aims to introduce a new feature Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Language: SQL PR or issue that update SQL code State: Needs work PR awaiting additional work by the author to proceed labels Aug 18, 2016
@MounaSafiHarab MounaSafiHarab added this to the 17.0 milestone Aug 18, 2016
@codecov-io
Copy link

codecov-io commented Aug 18, 2016 •
edited
Loading

Current coverage is 13.73% (diff: 0.00%)

Merging #2135 into 17.0-dev will increase coverage by 0.08%

@@           17.0-dev      #2135   diff @@
==========================================
  Files           118        118          
  Lines         20096      20084    -12   
  Methods        1120       1120          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2744       2759    +15   
+ Misses        17352      17325    -27   
  Partials          0          0

Sunburst

Powered by Codecov. Last update e557c55...a1df42e

@MounaSafiHarab MounaSafiHarab removed the State: Needs work PR awaiting additional work by the author to proceed label Aug 19, 2016
@gluneau gluneau added PassedCodeReview Passed manual tests PR has been successfully tested by at least one peer labels Aug 25, 2016
driusan
driusan reviewed Aug 29, 2016
View reviewed changes
SQL/0000-00-00-schema.sql
@@ -1040,6 +1040,7 @@ CREATE TABLE `session` (
`MRIQCPending` enum('Y','N') NOT NULL default 'N',
`MRIQCFirstChangeTime` datetime default NULL,
`MRIQCLastChangeTime` datetime default NULL,
`Caveat` enum('true','false') NOT NULL default 'false',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Caveat flag for the whole session, or just for the imaging?

It's on the session table, so it's a little confusing that it's called "session.Caveat" but referred to as "mricaveat" in the template.

@MounaSafiHarab
Copy link
Contributor Author

@driusan @gluneau
changed the name to be caveat as opposed to mricaveat to make it more generic

@MounaSafiHarab MounaSafiHarab removed PassedCodeReview Passed manual tests PR has been successfully tested by at least one peer labels Sep 1, 2016
@gluneau gluneau added PassedCodeReview Passed manual tests PR has been successfully tested by at least one peer labels Sep 8, 2016
@driusan driusan merged commit 5a23e0a into aces:17.0-dev Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gluneau gluneau

Labels
Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code Passed manual tests PR has been successfully tested by at least one peer Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MounaSafiHarab @codecov-io @driusan @gluneau