[Help Editor] Fix incorrect substr syntax #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
ridz1208
approved these changes
Jul 19, 2017
|
@sruthymathew123 please test |
kongtiaowang
added
the
Passed manual tests
|
The description in this PR is referring to itself. I think you included the wrong link. |
|
@driusan the link is now correct |
driusan
reviewed
Jul 19, 2017
| if (substr($key, "Topic") == 0) { | ||
| // Check if key starts with $needle ("Topic") | ||
| $needle = "Topic"; | ||
| if (substr($key, 0, strlen($needle)) === $needle) { |
There was a problem hiding this comment.
I think the logic of what this is trying to do would be a lot more intuitive if it was written as:
if (strpos($key, "Topic") === 0)
but since this fixes an immediate need I'll make that comment on the other, more long term PR and merge this..
There was a problem hiding this comment.
I think the longer-term PR can probably be used instead of both strpos and substr if we want to go that route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a syntax error in
help_editorwhich caused several PHP Warnings:substr() expects parameter 2 to be integer, string givenThis is the minimal change required to fix the bug. See also #2965 for a Utility method that will allow us to reuse this fix elsewhere (if needed).