[Help Editor] Fix array issues caused by super confusing code #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
added
Category: Bug
xlecours
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix help editor so that parent help topics are successfully retrieved
Prevent generation of PHP Notices relating to non-existing array keys
Rename variables to be descriptive
Add lots of comments to make code more understandable
I know normally we separate cleanup/refactoring from bug fixes but I was unable to fix the bug without first renaming and refactoring the code to make it clear what was actually being accomplished.
I've marked this as
17.1because it is a bug fix but if this needs to go to17.2because of refactoring changes that's also fine.