[Candidate] Functions moved to candidate class #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
the
Cleanup
johnsaigle
approved these changes
Aug 10, 2017
|
@driusan can this one go to 19.0 as well ? |
|
@ridz1208 Sure, sounds good to me. |
|
(but it needs to be rebased) |
driusan
pushed a commit
to driusan/Loris
that referenced
this pull request
Nov 6, 2017
This moves 2 static functions from the candidate_parameters class to the candidate class since they're used across different modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves 2 functions from the candidate_parameters class to the candidate library