[Data Dictionary] Update TestPlan to include testing of data_dictionary_builder.php #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidblader
added
Category: Documentation
johnsaigle
previously approved these changes
Aug 16, 2017
driusan
requested changes
Oct 5, 2017
modules/datadict/test/TestPlan
Outdated
| @@ -25,3 +25,5 @@ | |||
| [Automation Testing] | |||
| 9. Check that the maximum rows displayed dropdown works, also check that the download table as CSV works as well. | |||
| [Automation Testing] | |||
| 10. Check tools/data_dictionary_builder.php works. Try changing field names in an instrument before running script and | |||
| make sure that the corresponding entries in Data Dictionary are updated correctly. | |||
There was a problem hiding this comment.
There's some grammatical errors in this. It should be "Check that the [...] works." It should also be "before running the script".
kongtiaowang
added
the
State: Needs work
davidblader
removed
the
State: Needs work
|
@driusan please revise your review |
ridz1208
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestPlan for this module should include testing of related tool scripts