Fix empty result in getMaxThreadStatus for NDB_BVL_Feedback #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NDB_BVL_Feedback class incorrectly had a isset check instead of an !empty check to determine if an SQL query returned any results. isset would never be false, because the variable is set directly above the check. This updates it to be !empty, so that "null" is properly returned when there is no feedback.
kongtiaowang
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NDB_BVL_Feedback class incorrectly had a isset check instead of an !empty
check to determine if an SQL query returned any results. isset would never
be false, because the variable is set directly above the check.
This updates it to be !empty, so that "null" is properly returned when
there is no feedback.