[login] added slashes at the end of URL #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
Category: Bug
|
@driusan is there a way to test this ?? |
ridz1208
commented
Oct 11, 2017
| <a href="{$baseurl}/password-reset">Forgot your password?</a><br/> | ||
| <a href="{$baseurl}/request-account">Request Account</a> | ||
| <a href="{$baseurl}/password-reset/">Forgot your password?</a><br/> | ||
| <a href="{$baseurl}/request-account/">Request Account</a> |
There was a problem hiding this comment.
this is necessary since the htacess is expecting that slash (see link below)
https://github.com/aces/Loris/blob/minor/htdocs/.htaccess#L9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds slashes at the end of the password-reset and request-account urls because that is the expected behavior and in their absence nginx servers seem to throw a 301 error