Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument list: timePoint should be with capital P in hasAccess() #3182

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

MounaSafiHarab
Copy link
Contributor

@MounaSafiHarab MounaSafiHarab commented Oct 17, 2017

capital P in timePoint as per the definition on line 42 of the file being changed.

@MounaSafiHarab MounaSafiHarab added Category: Bug PR or issue that aims to report or fix a bug [branch] bugfix labels Oct 17, 2017
@MounaSafiHarab MounaSafiHarab added this to the 18.0.2 milestone Oct 17, 2017
@MounaSafiHarab
Copy link
Contributor Author

@davidblader

to test this; remove the has access all profiles permission and try to access any instrument in the instrument list of a candidate not in one of your sites using the 'Open Profile' dialog box from the top right corner of candidate list...
check before (500 error) and after!

@davidblader davidblader added the Passed manual tests PR has been successfully tested by at least one peer label Oct 17, 2017
@driusan driusan merged commit d377b02 into aces:bugfix Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants