Update configuration module README to follow imaging_browser template #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the configuration module readme.md to follow the template for module specifications set by the imaging_browser README. (It also renames the file to README.md to be more consistent.) The "How to use this module" part of the existing readmd was moved to markdown help content, while the "How to upgrade from config.xml" which was relevant for the LORIS 14.12 release was removed as it's no longer relevant.
driusan
added
Category: Documentation
PapillonMcGill
previously requested changes
Jan 25, 2018
| changes. You must press the submit button that is on the page where | ||
| you are making the changes for the changes to be stored in the | ||
| database. If you press the submit button on another configuration | ||
| page, it will not store any changes made on other pages. |
There was a problem hiding this comment.
The 2 last lines are not clear. Are we talking about change made this page, another page or other page.
What about:
Pressing the submit button on a page will not save change made on other pages.
There was a problem hiding this comment.
Thanks.. I didn't write the content, I just copied it from the old README, but I agree that your wording is more clear, so I updated it.
driusan
dismissed
PapillonMcGill’s stale review
I don't know why sometimes reviews get autodismissed and sometimes they don't, but these changes are done..
PapillonMcGill
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the configuration module readme.md to follow the template
for module specifications set by the imaging_browser README. (It also
renames the file to README.md to be more consistent.)
The "How to use this module" part of the existing readmd was moved unmodified to
markdown help content, while the "How to upgrade from config.xml"
which was relevant for the LORIS 14.12 release was removed as it's
no longer relevant.