-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next_stage spec #3409
Add next_stage spec #3409
Conversation
Add README to next_stage module
modules/next_stage/README.md
Outdated
|
||
## Purpose | ||
|
||
The `next_stage` module provides a method of start the "next stage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest "... method of starting the ..." or "... method to start the ... "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with "to" since it requires less formatting change..
modules/next_stage/README.md
Outdated
## Purpose | ||
|
||
The `next_stage` module provides a method of start the "next stage" | ||
of a candidate session. The "Stage" of an session goes from Screening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... of a session ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
modules/next_stage/README.md
Outdated
|
||
The `next_stage` module provides a method of start the "next stage" | ||
of a candidate session. The "Stage" of an session goes from Screening | ||
to Visit to Approval, and the Screening and Visit stages may have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval**. The** Screening ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
modules/next_stage/README.md
Outdated
|
||
## Scope | ||
|
||
The `next_stage` module only moves from the Screening to Visit stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest: ... only move the stage of a session from Screening to Visit.
modules/next_stage/README.md
Outdated
|
||
## Permissions | ||
|
||
Both the `data_entry` permission is required, and the user must be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there 2 permissions required?
one suggestion is : "The data_entry
permission is required. The user must also be at the same CenterID ..."
or "... The user wil only see the timepoint for CenterID where he is activated" or something similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both the explicit permission with the permission code, and the same CenterID (which isn't really a permission in the code sense, but affects access) is required.
I updated it to your wording, I think it's more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammatical change required, see comments
Add README to next_stage module.
Add README to next_stage module