Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Version] Version #3445

Merged
merged 1 commit into from
Feb 20, 2018
Merged

[Version] Version #3445

merged 1 commit into from
Feb 20, 2018

Conversation

ridz1208
Copy link
Collaborator

This fixes version number

@ridz1208 ridz1208 added the Critical to release PR or issue is key for the release to which it has been assigned label Jan 24, 2018
@ridz1208 ridz1208 added this to the 19.0 milestone Jan 24, 2018
@MounaSafiHarab MounaSafiHarab mentioned this pull request Jan 24, 2018
Merged
@ridz1208 ridz1208 closed this Jan 24, 2018
@driusan
Copy link
Collaborator

driusan commented Jan 24, 2018

why was this closed?

@ridz1208
Copy link
Collaborator Author

see linked PR
the change has been done there

@MounaSafiHarab
Copy link
Contributor

see linked PR
the change has been done there

what linked PR? the one I refer to is on the MRI side as I was tagging @christinerogers and @cmadjar for an MRI discussion!

@ridz1208 ridz1208 reopened this Jan 24, 2018
@ridz1208
Copy link
Collaborator Author

ooops

@ridz1208
Copy link
Collaborator Author

@driusan

@driusan
Copy link
Collaborator

driusan commented Jan 31, 2018

@ridz1208 I didn't merge it because it's an RC, not the final release.

christinerogers
christinerogers previously approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this pull request.

@driusan
Copy link
Collaborator

driusan commented Feb 19, 2018

This is really stupid, but.. can you rebase this so it passes Travis?

@kongtiaowang kongtiaowang reopened this Feb 19, 2018
@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Feb 19, 2018
@driusan driusan merged commit 073778a into aces:19.0-dev Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinerogers christinerogers christinerogers left review comments

Assignees
No one assigned
Labels
Critical to release PR or issue is key for the release to which it has been assigned Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Milestone
19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ridz1208 @driusan @MounaSafiHarab @christinerogers @kongtiaowang