Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOG cleanup] select to pselect #3454

Merged
merged 2 commits into from
Jan 31, 2018
Merged

[LOG cleanup] select to pselect #3454

merged 2 commits into from
Jan 31, 2018

Conversation

xlecours
Copy link
Contributor

This remove the last DB->select by changing them to pselect which use prepared statements.

More secured and clean the "PHP Warning: Missing argument 2 for Database::select()" message in the error log.

@xlecours xlecours added the Cleanup PR or issue introducing/requiring at least one clean-up operation label Jan 26, 2018
@xlecours xlecours added this to the 19.1 milestone Jan 26, 2018
driusan
driusan approved these changes Jan 31, 2018
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not more secure since there's no user input involved, but it makes it easier to deprecate the non-prepared version later..

@driusan driusan merged commit d1f1a86 into aces:minor Jan 31, 2018
@xlecours xlecours deleted the select_to_pselect branch August 4, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan approved these changes

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Milestone
19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@xlecours @driusan