Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor branch Travis #3495

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Fix minor branch Travis #3495

merged 3 commits into from
Feb 19, 2018

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Feb 15, 2018

This performs the same fix for Travis on minor as was just done on major to re-enable multiple versions of PHP being tested at once.

@driusan driusan requested a review from kongtiaowang February 15, 2018 19:01
@driusan driusan added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Feb 19, 2018
@driusan
Copy link
Collaborator Author

driusan commented Feb 19, 2018

This isn't really blocked, but a decision on how to deal with it needs to be made.

7.0 and 7.1 can't be tested together by Travis, because the command line that Travis requires is different between the two. 7.1 and 7.2 can't be tested on minor, because the fixes for the deprecated functions are only in the major branch.

Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Feb 19, 2018
@driusan driusan merged commit 5d6b9ea into aces:minor Feb 19, 2018
@ridz1208 ridz1208 added this to the 19.1 milestone Apr 17, 2018
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this pull request May 2, 2018
This makes the Travis testing on minor in sync with the major branch, although PHP 7.2 is not tested because the fixes are currently only in major.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants