Imaging Browser: Make Links to instruments project customizable and add the DICOM download: Redmines 12500 and 12580 #3496
Conversation
…dd the DICOM download: Redmines 12500 and 12580
MounaSafiHarab
added
Category: Feature
MounaSafiHarab
added
the
State: Needs rebase
|
not sure where to put the .sql patch within the Archive directory; |
| = $DB->tableExists('mri_parameter_form'); | ||
| $this->tpl_data['rad_review_table_exists'] = $DB->tableExists( | ||
| 'radiology_review' | ||
| ); |
There was a problem hiding this comment.
The tables should exist otherwise the user would not be able to select them in the Configuration module in the first place; so I thought these was no need for these few lines.
There was a problem hiding this comment.
but you include them as defaults in the patch? What's that going to do if they don't have the tables?
There was a problem hiding this comment.
it was the case for me for radiology_review table which does not exist in my dump; the patch will just simply run and won't add it without any error. But maybe it is best I add conditional addition (if table exists) to the patch?
|
IF this makes it to Loris, we will have one less override for CCNA (the good news for me, it happens to be the only one I need to maintain!)! |
|
@MounaSafiHarab This is tagged milestone 19.1 but going to branch 19.0. Can you fix one or the other? |
| @@ -0,0 +1,6 @@ | |||
| -- Add Imaging Browser to Imaging Modules | |||
| INSERT INTO ConfigSettings (Name, Description, Visible, AllowMultiple, DataType, Parent, Label, OrderNumber) SELECT 'linkedInstruments', 'Instruments that the users want to see linked from Imaging Browser', 1, 1, 'instrument', ID, 'Imaging Browser Links to Instruments', 7 FROM ConfigSettings WHERE Name="imaging_modules"; | |||
There was a problem hiding this comment.
Can you change the name to something link "ImagingBrowserLinkedInstruments"? "linkedInstruments" as a generic config name used throughout LORIS isn't really clear.
| $FullPath = $tarchivePath . '/' . $File; | ||
| $MimeType = 'application/x-tar'; | ||
| $DownloadFilename = basename($File); | ||
| break; |
There was a problem hiding this comment.
Can you split this into 2 PRs? The DICOM Tar download and the imaging browser linked instruments don't belong together.
There was a problem hiding this comment.
I will. I just wanted to see if there is interest in this. But I guess I will split them, basing it off of minor, and take care of your other comments in the newly sent pull requests to make it easier for review.
yes @driusan |
|
@MounaSafiHarab hopefully! |
As the title says: projects can now customize the instruments they want to see under links, and can download the DICOMs from Imaging Browser.
The second feature was started in #2791; but finished here.
The instruments are chosen as shown in screenshot below:
and
the Imaging Browser View Session Links would display:
