Copy of [Core-Database] added 2 new functions to help avoid code duplication #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
the
State: Discussion required
|
@driusan can we check this one out together ? |
ridz1208
added
Category: Feature
|
@driusan we discussed this one. Decision, this can be added to minor as it represents an exact copy of what was added to major in the PR linked above |
ZainVirani
added
the
Passed manual tests
This was referenced Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked commits from previous PR made to major, the PR belongs on minor and would be usefull to start cleaning up the code
#3428