Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Adding directories to separate new patches from clean-up patches from Archives #3531

Merged
merged 5 commits into from
Mar 12, 2018
Merged

[SQL] Adding directories to separate new patches from clean-up patches from Archives #3531

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d12c0
Directories created
ridz1208 Mar 2, 2018
93b72d5
Update README.md
ridz1208 Mar 5, 2018
3d7a87f
added clause
ridz1208 Mar 5, 2018
0ee38af
Update README.md
ridz1208 Mar 5, 2018
39769e3
Update README.md
ridz1208 Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SQL/Cleanup_patches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory contains SQL patches written for post-release cleanup. These patches can contain `ALTER TABLE`, `DELETE` and/or `DROP` statements. These patches should be run at the discretion of the projects with the full knowledge of the possible side effects of these patches. The content of these patches should not be mandotory for proper functioning of the database, they should be run for the sole purpose of removing unused tables, columns or fields; any mandatory cleanup should be added to the release patches.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention DELETE statement but near the end of the paragraph, you mention removing columns or fields, not rows.

Could you add precision about when DELETE could be used? or remove DELETE statement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rows should be there as well, adding it to the readme

0 ...9.1/2017-04-24-UseOurIssueTrackerPl0x.sql → ...hes/2017-04-24-UseOurIssueTrackerPl0x.sql
View file
Open in desktop
File renamed without changes.
0 .../2017-06-13-addUserLanguagePreference.sql → .../2017-06-13-addUserLanguagePreference.sql
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions SQL/New_patches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This directory contains SQL patches necessary during the upgrade of LORIS. Upon release, the SQL patches concerned will be concatenated into a single release patch stored under the `SQL/Release_patches` directory. The files used for the concatenation are then moved to the `SQL/Archive/X.Y` directory. These patches are necessary for each release and the concatenated version should always be run in parallel to the code changes.