Fix some phan problems #3533
Merged
Fix some phan problems #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This randomly fixes some classes of issues detected by phan
ZainVirani
suggested changes
Mar 5, 2018
| * | ||
| * @return string the page content | ||
| * @return ResponseInterface The response with the the page content |
| */ | ||
| public function __construct( | ||
| IDatabaseProvider $databaseProvider = null |
There was a problem hiding this comment.
If the constructor is called with a null databaseProvider, why is $this->_databaseProvider not set to new DefaultDatabaseProvider() here instead of in the get function?
There was a problem hiding this comment.
You'd have to ask the person who wrote the code, I just fixed the bug that phan found. null isn't a valid value, because it's defined as taking an IDatabaseProvider in the signature, so it would crash with a runtime error if you called it that way anyways
There was a problem hiding this comment.
(the other problem that phan detected is that the doc comment said it was a "mixed" param type, but the actual signature in PHP was declared as IDatabaseProvider..)
ZainVirani
approved these changes
Mar 5, 2018
xlecours
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This randomly fixes some classes of issues detected by phan and updates the phan config to ensure no regressions.