Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a typo in the config table #3550

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fixed a typo in the config table #3550

merged 1 commit into from
Mar 19, 2018

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Mar 16, 2018

This pull request fixes a typo in the Config table that got inserted by #3449. 'to to' becomes 'to'

@cmadjar cmadjar added Cleanup PR or issue introducing/requiring at least one clean-up operation Language: SQL PR or issue that update SQL code [branch] major labels Mar 16, 2018
@cmadjar cmadjar added this to the 20.0 milestone Mar 16, 2018
@cmadjar cmadjar requested a review from MounaSafiHarab March 16, 2018 14:43
@cmadjar cmadjar mentioned this pull request Mar 16, 2018
Merged
HenriRabalais
HenriRabalais approved these changes Mar 19, 2018
View reviewed changes
Copy link
Collaborator

@HenriRabalais HenriRabalais left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No need for two to's!

driusan
driusan approved these changes Mar 19, 2018
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing because of something that's already fixed in the major branch, so I'm just merging instead of rebasing and waiting for travis again..

@driusan driusan merged commit 04e6c0e into aces:major Mar 19, 2018
@cmadjar cmadjar deleted the FixTypoInConfigModule branch April 9, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan approved these changes

@HenriRabalais HenriRabalais HenriRabalais approved these changes

@MounaSafiHarab MounaSafiHarab Awaiting requested review from MounaSafiHarab

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Language: SQL PR or issue that update SQL code
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cmadjar @driusan @HenriRabalais