Remove non-prepared variant of database select wrappers #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Release: Add to release notes
|
This is a very good idea Dave! Happy that it's happening. |
ridz1208
added
the
State: Needs rebase
|
@driusan 35 seconds later... you have a conflict |
The non-prepared variant of the database select wrappers have been deprecated for a long time, but left around because of the need of projects to update any instruments they might have that uses them. This finally removes the code, now that users have had time to update any calls to them and all references in the LORIS codebase have been removed.
driusan
force-pushed
the
RemoveDeprecatedDatabaseFunctions
branch
from
14d971c to
33ae1ab
Compare
xlecours
reviewed
Mar 19, 2018
| * @access public | ||
| * @deprecated Use pselect wrappers instead | ||
| */ | ||
| function selectRow($query, &$result) |
There was a problem hiding this comment.
docs/instruments/NDB_BVL_Instrument_mri_parameter_form.class.inc will be sad
| * @access public | ||
| * @deprecated Use pselect wrappers instead | ||
| */ | ||
| function select($query, &$result) |
driusan
removed
the
State: Needs rebase
|
@xlecours Done and Done please re-review |
kongtiaowang
added
the
Passed manual tests
PapillonMcGill
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-prepared variant of the database select wrappers have been
deprecated for a long time, but left around because of the need of
projects to update any instruments they might have that uses them.
This finally removes the code, now that users have had time to
update any calls to them and all references in the LORIS codebase
have been removed.
See also: comments on #3544